Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate block builder functionality from BABE session #882

Closed
2 of 3 tasks
noot opened this issue May 21, 2020 · 3 comments · Fixed by #1602
Closed
2 of 3 tasks

separate block builder functionality from BABE session #882

noot opened this issue May 21, 2020 · 3 comments · Fixed by #1602

Comments

@noot
Copy link
Contributor

noot commented May 21, 2020

Expected Behavior

  • the block building functionality (ie lib/babe/build.go) should be separated into a separate submodule
  • this will make testing easier for other packages that need to build blocks, but don't need an entire BABE session

Current Behavior

  • block building requires a BABE session

Possible Solution

  • create a new BlockBuilder type that implements the functions in lib/babe/build.go

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT
  • I have provided as much information as possible and necessary
  • I am planning to submit a pull request to fix this issue myself
@danigomez
Copy link
Contributor

danigomez commented May 14, 2021

Hello everyone!
I found this project while reading the Polkadot documentation and i found it very interesting!
I want to start working on this, but i'm not sure if this is still necessary, reviewing the code i found that the BuildBlock method was being used in the test file dot/core/syncer_test.gobut it seems that it doesn't exists anymore.
Am i missing something?
Thanks!

@noot
Copy link
Contributor Author

noot commented May 14, 2021

@danigomez hi, for this issue you would only need to modify the lib/babe package to create a separate blockBuilder type or such that has the functions used for block building (lib/babe/build.go) defined on it. the babe Service can then use this blockBuilder to build a block. let me know if you need more clarification!

@danigomez
Copy link
Contributor

@noot Ok!, i will start working on this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants