Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dot/types): *types.Body to be of type []types.Extrinsic #1807

Merged
merged 13 commits into from
Oct 5, 2021
Merged

fix(dot/types): *types.Body to be of type []types.Extrinsic #1807

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9dd327a
BodyExtrinsics instead of Body
kishansagathiya Sep 28, 2021
6cb67a8
Merge branch 'development' into issue-1775
kishansagathiya Sep 28, 2021
70cd6d1
Tests for BodyExtrinsics, Removed old Body struct
kishansagathiya Sep 28, 2021
51cbe83
Rename BodyExtrinsics to Body
kishansagathiya Sep 28, 2021
3caeae9
Addressed some reviews and left over renaming
kishansagathiya Sep 29, 2021
5d04036
Fixing a bug
kishansagathiya Sep 29, 2021
17016ec
Addressed some more minor comments
kishansagathiya Sep 30, 2021
376848c
Optimized slice intialization
kishansagathiya Sep 30, 2021
b9db066
Merge branch 'development' into issue-1775
kishansagathiya Oct 1, 2021
e3c856d
Fix a linting issue
kishansagathiya Oct 1, 2021
aa9ac8b
Merge branch 'development' into issue-1775
kishansagathiya Oct 1, 2021
afe1ebb
Merge branch 'development' into issue-1775
noot Oct 5, 2021
760b2af
Merge branch 'development' into issue-1775
noot Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dot/types/body.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func NewBodyFromExtrinsicStrings(ss []string) (*Body, error) {

// DeepCopy creates a new copy of the body.
func (b *Body) DeepCopy() Body {
newExtrinsics := make([]Extrinsic, len([]Extrinsic(*b)))
newExtrinsics := []Extrinsic{}
kishansagathiya marked this conversation as resolved.
Show resolved Hide resolved

for _, e := range []Extrinsic(*b) {
temp := make([]byte, len(e))
Expand Down