Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove PR body and title checks #2456

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Apr 1, 2022

Changes

  • Remove PR body+title check CI workflow job (it annoyed me too much, and is frustrating to newcomers as well)
  • Remove PR Go verification code
  • Simplify PR body template, but keep the same sections
  • ⚠️ before merging this, we need to remove the requirement for the PR check workflow in the repo settings

Why?

  • Newcomers have trouble making it pass, for example in fix(lib/runtime): avoid caching version in runtime instance #2425 they got frustrated from it
  • For once all the CI passed BUT the PR title check in chore(tests): do not osExit and return error #2452 and changing the title+restarting the job will still fail... I got angry at it
  • It's just more trouble than advantages. Developers will likely respect the existing template, and, if they don't, might have a reason for it. We can always document it with a comment on the PR template if we really get randomly formed PR bodies in the future.

Tests

Issues

Primary Reviewer

@timwu20

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Co-authored-by: Timothy Wu <timwu20@gmail.com>
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2456 (c73a658) into development (19a2b4e) will increase coverage by 3.00%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #2456      +/-   ##
===============================================
+ Coverage        58.54%   61.54%   +3.00%     
===============================================
  Files              214      215       +1     
  Lines            28004    28184     +180     
===============================================
+ Hits             16396    17347     +951     
+ Misses            9956     9075     -881     
- Partials          1652     1762     +110     
Flag Coverage Δ
unit-tests 61.54% <ø> (+3.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/gossip.go 86.36% <0.00%> (-13.64%) ⬇️
dot/network/transaction.go 53.06% <0.00%> (-10.28%) ⬇️
dot/network/inbound.go 92.98% <0.00%> (-7.02%) ⬇️
dot/network/block_announce.go 58.40% <0.00%> (-6.01%) ⬇️
dot/network/message_cache.go 53.65% <0.00%> (-4.68%) ⬇️
dot/telemetry/mailer.go 56.71% <0.00%> (-4.48%) ⬇️
internal/trie/node/decode.go 96.07% <0.00%> (-3.93%) ⬇️
dot/network/message.go 65.80% <0.00%> (-3.20%) ⬇️
dot/network/notifications.go 65.17% <0.00%> (-2.33%) ⬇️
dot/state/epoch.go 48.08% <0.00%> (-1.92%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e700d5e...c73a658. Read the comment docs.

@qdm12 qdm12 merged commit f6bac28 into development Apr 6, 2022
@qdm12 qdm12 deleted the qdm12/remove-pr-check branch April 6, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants