feat: remove unnecessary conversion from Multiaddr to IP #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good change, here's the event you're looking for: https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interface-peer-store/src/index.ts#L209 |
wemeetagain
changed the title
wemeetagain
force-pushed
the
dapplion/drop-is-ip
branch
from
2817fcb to
f23795f
Compare
Codecov ReportBase: 83.58% // Head: 83.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 83.58% 83.26% -0.32%
==========================================
Files 47 48 +1
Lines 11771 11779 +8
Branches 1266 1264 -2
==========================================
- Hits 9839 9808 -31
- Misses 1932 1971 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
✔️ looks good! Can't approve since it's my PR |
wemeetagain
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gossipsub currently polls connection manager frequently to figure what IPs each peer connection has. This is very inneficient and causes performance issues in Lodestar
Instead js-libp2p should follow a similar pattern to rust-libp2p, which injects an
AddressChangeevent into protocols. See https://github.com/sigp/rust-libp2p/blob/a3dec471c046127e8e0d88bc89a881affb56a76c/protocols/gossipsub/src/behaviour.rs#L3282@achingbrain is js-libp2p emitting a similar event already? Where could this be added if not?