Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .js extension to imported file #370

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

AlexMesser
Copy link
Contributor

Added .js extension to imported file since compiler gives an error:

Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './rpc.js'?

with "moduleResolution" option set to "NodeNext"

Added `.js` extension since compiler gives an error `Relative import paths need explicit file extensions in EcmaScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Did you mean './rpc.js'?` with `"moduleResolution": "NodeNext"` option.
@AlexMesser AlexMesser requested a review from a team as a code owner November 3, 2022 15:21
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2022

CLA assistant check
All committers have signed the CLA.

@AlexMesser AlexMesser changed the title Add .js extension to imported file fix: add .js extension to imported file Nov 3, 2022
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wemeetagain wemeetagain merged commit 129b9cd into ChainSafe:master Nov 3, 2022
@AlexMesser AlexMesser deleted the patch-1 branch November 4, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants