-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update readme code example to new API. #382
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign CLA agreement
I don't believe these CLAs are healthy to the opensource ecosystems since they are non-standard and contain legalese that only someone with good understanding of it can fully understand the extent of its meaning. Therefore I will not be signing it, however someone who has the ability to make the changes should update the readme to reflect the new API in a similar fashion to what I have done. |
Not sure why we have the CLA here since this is a permissively licensed repo 🤔 |
I think because of that ethereum c++ client that couldn't change license as external contributors were claiming that they only submitted code under previous license so CLA forces everyone to give out any rights to submitted code to chainsafe |
Shouldn't that only be an issue when code isn't permissively licensed? The c++ ethereum client was GPL licensed. |
Codecov ReportBase: 83.29% // Head: 83.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 83.29% 83.26% -0.04%
==========================================
Files 48 48
Lines 11779 11787 +8
Branches 1265 1266 +1
==========================================
+ Hits 9811 9814 +3
- Misses 1968 1973 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We've agreed that CLA agreements for Lodestar should not exist on libraries such as this one, but only retained for our main Lodestar monorepo. @q9f is in the process of helping us to remove this requirement and hopefully that will allow this PR to be merged if there's no additional issues. |
You can ignore CLA here. It's not meant for the libraries. |
This PR simply fixes the code example provided by the readme.