Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove noise pipes option #177

Merged
merged 5 commits into from
Aug 10, 2022
Merged

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Aug 2, 2022

As discussed offline, not need to keep code that will probably be never used

BREAKING CHANGE: noise pipes option no longer supported

@dapplion dapplion requested a review from a team as a code owner August 2, 2022 17:57
@dapplion dapplion requested a review from wemeetagain August 2, 2022 17:57
@mpetrunic mpetrunic changed the title Remove un-used handshakes chore!: remove un-used handshakes Aug 2, 2022
@mpetrunic mpetrunic changed the title chore!: remove un-used handshakes chore!: remove noise pipes option Aug 2, 2022
@mpetrunic
Copy link
Member

@dapplion lint errors^^

@dapplion
Copy link
Contributor Author

dapplion commented Aug 2, 2022

@dapplion lint errors^^

So I had to disable prettier for this repo because it completely changed everything. But then there's this linter? So in Lodestar prettier is connected to the linter such that VSCode can understand what the linter wants and apply that automatically for you if you have { "editor.formatOnSave": true }. How do you handle that with aegir?

@mpetrunic
Copy link
Member

@dapplion lint errors^^

So I had to disable prettier for this repo because it completely changed everything. But then there's this linter? So in Lodestar prettier is connected to the linter such that VSCode can understand what the linter wants and apply that automatically for you if you have { "editor.formatOnSave": true }. How do you handle that with aegir?

For me it detected. Do you have this checked:
image

@mpetrunic
Copy link
Member

@dapplion since this is breaking change, should we wait with releasing until we land changed connection encrypted interface?

@mpetrunic
Copy link
Member

@dapplion since this is breaking change, should we wait with releasing until we land changed connection encrypted interface?

@wemeetagain^^

@wemeetagain
Copy link
Member

yea lets wait, should happen soon

src/noise.ts Outdated
@@ -220,7 +145,7 @@ export class Noise implements INoiseConnection {
await handshake.exchange()
await handshake.finish()

if (this.useNoisePipes && handshake.remotePeer) {
if (handshake.remotePeer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition and keycache store should be removed

@dapplion
Copy link
Contributor Author

dapplion commented Aug 7, 2022

@dapplion lint errors^^

So I had to disable prettier for this repo because it completely changed everything. But then there's this linter? So in Lodestar prettier is connected to the linter such that VSCode can understand what the linter wants and apply that automatically for you if you have { "editor.formatOnSave": true }. How do you handle that with aegir?

For me it detected. Do you have this checked: image

Still not working, I can DM to debug

@mpetrunic
Copy link
Member

@achingbrain aegir dep-check is passing without warnings or errors for unused prod dependencies. Is that normal?

@mpetrunic mpetrunic merged commit a43cba9 into master Aug 10, 2022
@mpetrunic mpetrunic deleted the dapplion/unused-handshakes branch August 10, 2022 13:45
@mpetrunic mpetrunic mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants