Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve decode performance with subarray #49

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: improve decode performance with subarray #49

merged 1 commit into from
May 8, 2023

Conversation

wemeetagain
Copy link
Member

Related to #42

subarray may reuse the underlying buffer instead of copying

@wemeetagain wemeetagain requested review from a team and achingbrain as code owners May 5, 2023 17:29
maschad
maschad approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wemeetagain wemeetagain merged commit 684de7c into master May 8, 2023
@wemeetagain wemeetagain deleted the cayman/decode-perf branch May 8, 2023 14:13
github-actions bot pushed a commit that referenced this pull request May 17, 2023
@semantic-release-bot
chore(release): 4.0.2 [skip ci]
dc55dcf 
## [4.0.2](v4.0.1...v4.0.2) (2023-05-17)

### Bug Fixes

* improve decode performance with subarray ([#49](#49)) ([684de7c](684de7c))

### Dependencies

* upgrade deps ([#52](#52)) ([d00570c](d00570c))
@github-actions
Copy link

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain achingbrain is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wemeetagain @maschad