Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name objects and arrays where possible #3445

Closed
dapplion opened this issue Nov 19, 2021 · 2 comments
Closed

Name objects and arrays where possible #3445

dapplion opened this issue Nov 19, 2021 · 2 comments
Labels
prio-medium Resolve this some time soon (tm). scope-memory Issues to reduce and improve memory usage.

Comments

@dapplion
Copy link
Contributor

Describe the bug

When taking heap snapshots most of the memory is retained by literal objects and arrays. Where possible we should use classes or object constructors such that the object has a name. I did some tests and there's no extra memory cost

Screenshot from 2021-11-19 22-29-45

Expected behavior

Help identify memory issues faster

@dapplion dapplion added the scope-memory Issues to reduce and improve memory usage. label Nov 19, 2021
@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Feb 4, 2022
@philknows
Copy link
Member

This is a valuable improvement for debugging memory. Please assign @dapplion

@wemeetagain
Copy link
Member

this is valuable information for debugging but this issue is not actionable as it is written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-memory Issues to reduce and improve memory usage.
Projects
None yet
Development

No branches or pull requests

3 participants