Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase target peers to 100, max peers to 110 #5799

Closed
twoeths opened this issue Jul 25, 2023 · 4 comments · Fixed by #6556
Closed

Increase target peers to 100, max peers to 110 #5799

twoeths opened this issue Jul 25, 2023 · 4 comments · Fixed by #6556
Assignees
Labels
meta-feature-request Issues to track feature requests.

Comments

@twoeths
Copy link
Contributor

twoeths commented Jul 25, 2023

Problem description

Gradually all nodes will subscribe to exactly 2 subnets per node due to ethereum/consensus-specs#3312 so it'll not easy to find enough subnet peers

Solution description

We should track different things:

Additional context

Also other clients already increased to 100 peers (lighthouse, nimbus), lodestar should do the same

@twoeths twoeths added the meta-feature-request Issues to track feature requests. label Jul 25, 2023
@dapplion
Copy link
Contributor

@tuyennhv we should review the flood publish strategy into publishing to only a subset of subscribed peers. Can you review other clients strategies? Nimbus runs nodes with 2500 peers and has very reasonable outbound bandwidth

@philknows
Copy link
Member

@twoeths
Copy link
Contributor Author

twoeths commented Mar 26, 2024

need to figure out if it causes more delay when publishing block or not when increasing to 100 peers because we send published messages to all peers, see #6596

@twoeths
Copy link
Contributor Author

twoeths commented Mar 26, 2024

need to also take heap snapshot of network thread (when it's >= 2GB) + main thread (after increase target peers to 100). See #6556 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-feature-request Issues to track feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants