Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning log to validator client if primary node is unhealthy #6611

Closed
nflaig opened this issue Mar 28, 2024 · 0 comments · Fixed by #6921
Closed

Add warning log to validator client if primary node is unhealthy #6611

nflaig opened this issue Mar 28, 2024 · 0 comments · Fixed by #6921
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.

Comments

@nflaig
Copy link
Member

nflaig commented Mar 28, 2024

Problem description

Right now, the validator client is pretty silent about the primary node being unhealthy. We recently added metrics and dashboard panels to show the status of connected nodes (#6415) but we only log requests to fallback nodes to debug which many users do not look at.

Solution description

Add warning log to validator client if primary node is unhealthy as suggested by seamonkey.

We could use the same approach to flag the primary node as unhealthy if score is at 0. This would prevent false positives if just a single request fails which might happen due to other reasons.

Additional context

Related to #6415

@nflaig nflaig added good first issue Issues that are suitable for first-time contributors. scope-logging Issue about logs: hygiene, format issues, improvements. meta-feature-request Issues to track feature requests. labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests. scope-logging Issue about logs: hygiene, format issues, improvements.
Projects
None yet
1 participant