-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sliceFrom
to ListCompositeTreeViewDU
#366
Conversation
Performance Report✔️ no performance regression detected Full benchmark results
|
sliceFrom
to ListCompositeTreeViewDU
sliceFrom
to ListCompositeTreeViewDU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have some specs for this particular behavior? If yes please mention in the PR description.
Updated. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For library usage, it would be nice to also include sliceFrom
for ListBasicTreeViewDU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than @wemeetagain feedback LGTM.
Co-authored-by: Cayman <caymannava@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Add
sliceFrom
toListCompositeTreeViewDU
.Used in EIP-7251 to slice various beacon state fields like
pendingBalanceDeposit
,pendingConsolidation
during epoch processing.Refer to the spec for more details:
process_pending_balance_deposits
process_pending_consolidations
process_withdrawals