-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SIMD implementation for as-sha256 #367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
reviewed
Apr 19, 2024
g11tech
previously approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wemeetagain
reviewed
Apr 29, 2024
wemeetagain
previously approved these changes
May 22, 2024
twoeths
force-pushed
the
tuyen/digest_64_simd_2
branch
from
May 23, 2024 06:37
0b80769
to
82bcedb
Compare
g11tech
approved these changes
May 23, 2024
wemeetagain
approved these changes
May 23, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SIMD is available in assemblyscript, it supports v128 data structure which mean we can hash 4 inputs in parallel
Description
assembly/simd.ts
hash4Input64s(inputs: Uint8Array[]): Uint8Array[]
hash8HashObjects(inputs: HashObject[])
Closes #356