Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init web3 eth accounts 4.x #4496

Merged
merged 3 commits into from
Oct 27, 2021
Merged

init web3 eth accounts 4.x #4496

merged 3 commits into from
Oct 27, 2021

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 25, 2021 •
edited
Loading

Description

This PR have code for init of 4.x web3-eth-accounts package
and also minor fix in web3-core readme file

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@jdevcs jdevcs added the 4.x 4.0 related label Oct 25, 2021
@jdevcs jdevcs mentioned this pull request Oct 25, 2021
Closed
3 tasks
spacesailor24
spacesailor24 suggested changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter that much, but why is packages/web3-core/README.md included in this PR? Also version number needs to be changed, as this package hasn't been released yet for 4.x

@jdevcs jdevcs requested a review from spacesailor24 October 26, 2021 09:40
@jdevcs jdevcs merged commit 5eae2f4 into 4.x Oct 27, 2021
@jdevcs jdevcs deleted the junaid/init-web3-eth-accounts branch October 27, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@luu-alex luu-alex luu-alex approved these changes

@spacesailor24 spacesailor24 spacesailor24 approved these changes

Assignees
No one assigned
Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdevcs @nazarhussain @spacesailor24 @luu-alex