Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In non-privileged watch and blacklist PRs, make the automatic title indicate the type of watch or blacklist #12205

Open
gparyani opened this issue Jul 22, 2024 · 2 comments · May be fixed by #12206
Labels

Comments

@gparyani
Copy link
Contributor

gparyani commented Jul 22, 2024

Currently, the title of automatic PRs filed as a result of commands from non-privileged users indicate whether the user is requesting a watch or a blacklist, but don't indicate the specific type of request the user is making (e.g., which blacklist the user is requesting to add to). The only way to know is to open the PR and look.

I propose that the titles be reformatted to state something like:

  • "Amy Rose: Watch number 1234567890"
  • "Dr. Eggman: Blacklist keyword (?-i:Chaos Emeralds)"
  • "Silver the Hedgehog: Blacklist website gray\.fur"

This seems important to me since PRs can be approved in chat without opening them up on GitHub. The automatic message posted when a PR is opened only indicates the title, so there is no way to catch, for example, a user mistakenly adding a website to the keyword blacklist without clicking through to GitHub, which users aren't likely to do if the command was executed in a room other than Charcoal HQ.

gparyani added a commit to gparyani/SmokeDetector that referenced this issue Jul 22, 2024
@gparyani
Copy link
Contributor Author

The commit above is a code change that implements this. I opened a separate issue to better allow for discussion.

@gparyani
Copy link
Contributor Author

gparyani commented Aug 1, 2024

As noted in #12206 (comment), the above code change has been tested and confirmed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants