Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChartUtils methods are marked internal and cannot be use to create custom charts #1518

Closed
mpiannucci opened this issue Sep 21, 2016 · 2 comments

Comments

@mpiannucci
Copy link

mpiannucci commented Sep 21, 2016

For example, the ChartUtils.getPosition method is very useful when creating a custom Renderer but it may not be used unless I develop my work in the actual Charts git repo instead of just in my own project.

Please consider opening up these utilities for use in subclasses.

These functions are also marked public in the Android version so it would help with consistency as well.

@mpiannucci
Copy link
Author

Actually even more than that, there are a lot of random methods marked internal that make subclassing existing chart types really difficult. (EG the initialize function in PieRadarChartViewBase)

@danielgindi
Copy link
Collaborator

Why not call the super constructor?
Many internal methods are in fact internal. Some internal methods are meant to be "protected", not for public use by the user by available to subclasses - but Apple decided that protected is not useful enough to be in Swift.
Anyway - there was already an issue about that - #357

If there are methods that you think are legitimate to become public, raise them here for discussion and make a PR later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants