Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A scatter chart that preserves the order of the XY data pairs #170

Open
gjpc opened this issue Jun 23, 2015 · 6 comments
Open

A scatter chart that preserves the order of the XY data pairs #170

gjpc opened this issue Jun 23, 2015 · 6 comments
Labels

Comments

@gjpc
Copy link

gjpc commented Jun 23, 2015

This is a feature request. It would be nice to have a scatter chart that does not throw out the order that the XY pairs are placed into the data set for the expediency of speed. This will prevent non ascending ordered XY pairs from disappearing from the chart while zooming and panning.

@danielgindi
Copy link
Collaborator

Would you care to try to implement? Extending or duplicating the existing ScatterChart would be a great start ;-)

@gjpc
Copy link
Author

gjpc commented Jun 30, 2015

Sure Daniel,

I already have a working version in my branch https://github.com/gjpc/ios-charts

Would it be more helpful to you if I rename the object to IindependentScatterChart so you may merge it without effecting the original? This way if you use the chart you know you are going to take the speed hit and I don;t have to add code to do the breaks.

I also added the option to draw the lines between non-ordered pairs. You can see a sample in my branch's README.ME.

@danielgindi
Copy link
Collaborator

Yes of course!

@gjpc
Copy link
Author

gjpc commented Jul 2, 2015

Hi Daniel. Please excuse my unfamiliarity with git hub, I did not mean to push anything into your repo I was trying to update my repo to your latest revisions. I have updated my branch with what I think is your upstream master branch as of the time of this comment. I have no changes in existing Charts files, just added the IndependentScatter* swift files and of course the Charts project file.

I modified the demo project adding IndependentScatterChart.

I think my branch is ready to merge with the main. But I have no idea how to do this. Please advise.

@gjpc
Copy link
Author

gjpc commented Aug 29, 2015

I released a better demo today on my branch https://github.com/gjpc/ios-charts

@gjpc
Copy link
Author

gjpc commented Aug 31, 2015

@danielgindi I extended the lines to the axis of there is an out of viewport data point as per #130 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants