Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChartMaker work wrong in a Combined Chart #2692

Open
xzysun opened this issue Aug 9, 2017 · 3 comments
Open

ChartMaker work wrong in a Combined Chart #2692

xzysun opened this issue Aug 9, 2017 · 3 comments
Labels
bug enhancement

Comments

@xzysun
Copy link

xzysun commented Aug 9, 2017

https://github.com/danielgindi/Charts/blob/e72f28061eea69f6dcb1b684b709946f50c87610/Source/Charts/Charts/ChartViewBase.swift#L611-L614

It seems that when using combined chart with marker, the code can't get data set from data by highlight dataset index. The CombinedChartView.data.dataset is an empty array, and the real data is in CombinedChartView.data.lineData.dataset or CombinedChartView.data.barData.dataset
@liuxuan30
Copy link
Member

yes you have to override this methods for combined chart view now.

@xzysun
Copy link
Author

xzysun commented Aug 11, 2017 •
edited
Loading

https://github.com/danielgindi/Charts/blob/e72f28061eea69f6dcb1b684b709946f50c87610/Source/Charts/Charts/ChartViewBase.swift#L598

the method is internal, so can it be override in subclass?

@xzysun xzysun mentioned this issue Aug 11, 2017
Merged
@liuxuan30
Copy link
Member

liuxuan30 commented Aug 14, 2017 •
edited
Loading

of course. Unless you are using outside of the module

@liuxuan30 liuxuan30 mentioned this issue Aug 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xzysun @liuxuan30