Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChartsDemo doesn't compile #3116

Closed
valeriyvan opened this issue Dec 19, 2017 · 4 comments
Closed

ChartsDemo doesn't compile #3116

valeriyvan opened this issue Dec 19, 2017 · 4 comments

Comments

@valeriyvan
Copy link
Contributor

ChartsDemo target of ChartsDemo project is not compiling after last changes
@valeriyvan valeriyvan mentioned this issue Dec 19, 2017
Merged
@liuxuan30
Copy link
Member

liuxuan30 commented Dec 19, 2017 •
edited
Loading

I just checked the CI log. It just compiles the framework and run UT, not compiling the demos. I think we should avoid that in the future. Like adding a UT to build demos. @jjatie. I will try tomorrow to add.

@jjatie
Copy link
Collaborator

jjatie commented Dec 19, 2017

Sounds like a good idea to add compiling demos to the CI. I often forget to check them.

@liuxuan30 liuxuan30 mentioned this issue Dec 20, 2017
Merged
@jjatie
Copy link
Collaborator

jjatie commented Dec 24, 2017

I just checked the master and the demos (Mac and iOS objc/swift) are building fine.

@liuxuan30
Copy link
Member

liuxuan30 commented Dec 25, 2017 •
edited
Loading

Shall we merge #3121 then? BTW, please check #3121 comments, do you know anything we can reduce the compile times?
damn, I forgot add OS X demos tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valeriyvan @liuxuan30 @jjatie