Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: On mobile devices, pressing Enter by default does not send the message, but performs a normal line break #5473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rxliuli
Copy link

@rxliuli rxliuli commented Sep 19, 2024

…message, but performs a normal line break

💻 变更类型 | Change Type

  • fix On mobile devices, pressing Enter by default does not send the message, but performs a normal line break

🔀 变更说明 | Description of Change

Just like ChatGPT, use Enter to send messages on desktop? No problem, I can use Shift+Enter for line breaks. Do the same on mobile? That's strange. This is ChatGPT's different behavior on desktop and mobile.

Untitled.video.5.mp4

📝 补充信息 | Additional Information

Summary by CodeRabbit

  • New Features
    • Enhanced user input submission conditions to restrict submissions on mobile screens when no prompt hints are available, improving user experience based on device type.

Copy link

vercel bot commented Sep 19, 2024

@rxliuli is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The pull request modifies the _Chat function in app/components/chat.tsx to include a conditional check that restricts user input submission based on screen size. Specifically, it prevents submissions on mobile screens when there are no prompt hints, altering the conditions under which user input can be submitted.

Changes

File Change Summary
app/components/chat.tsx Added a condition to restrict user input submission on mobile screens when promptHints.length is zero.

Possibly related PRs

Suggested reviewers

  • Dogtiti
  • lloydzhou

Poem

🐇 In the chat where bunnies play,
Submissions now have rules to stay.
On mobile screens, they can't be sent,
When hints are few, it’s time to vent.
So hop along, dear friends, be wise,
For every chat, a new surprise! 🌟


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2474d5b and 79b46d7.

Files selected for processing (1)
  • app/components/chat.tsx (1 hunks)
Additional comments not posted (1)
app/components/chat.tsx (1)

Line range hint 1101-1106: LGTM!

The onInputKeyDown function correctly handles the submission of user input by checking the necessary conditions, such as the Enter key press, empty prompt hints, and non-mobile screen. This ensures a good user experience and prevents unintended auto-submission.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Your build has completed!

Preview deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant