Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different security policy for validating certificates against CAs #1072

Merged
merged 1 commit into from
Dec 8, 2018

Conversation

mimi89999
Copy link
Contributor

No description provided.

The policy that was used for showing information about certificate validity didn't validate domains

Closes ChatSecure#1071
@mimi89999
Copy link
Contributor Author

In several days I will make another PR that will make certificate pinning optional.

@chrisballinger
Copy link
Member

@mimi89999 Thank you! I will take some time to test this and try to get a new release out shortly.

I have been considering making cert pinning optional for a long time. As long as it's toggled on a per-account basis, and that the default behavior for accounts migrated from older versions is the same (e.g. keep legacy accounts pinned by default), your next PR should be good to merge.

@mimi89999
Copy link
Contributor Author

I was considering making certificate pinning a global setting as it is in Conversations and other applications. Why should it be per account?

@chrisballinger
Copy link
Member

My thoughts were that different accounts may have different security requirements. You might not be as concerned about a certificate change on a lower risk account than another one used for more sensitive communications.

@chrisballinger chrisballinger merged commit 507b14a into ChatSecure:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants