Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the puppet version to satisfy the Wechaty requirement #1453

Closed
huan opened this issue Jul 10, 2018 · 1 comment
Closed

Check the puppet version to satisfy the Wechaty requirement #1453

huan opened this issue Jul 10, 2018 · 1 comment
Labels
bug

Comments

@huan
Copy link
Member

huan commented Jul 10, 2018 •
edited
Loading

According to #1440 (comment), if there's an old version of PuppetPuppeteer in the node_modules when Wechaty is started, we should check whether the version could satisfy the Wechaty requirement, or we need to reinstall the right version before the start.

What we need check should include all the puppet implementations(wechaty-puppet-xxx) and the puppet abstract itself! (wechaty-puppet) See: #1440 (comment)
@huan huan added the bug label Jul 10, 2018
huan added a commit that referenced this issue Jul 12, 2018
@huan
check installed puppet version to match the wechaty required range (#…
ca9def4 
…1453)
@huan
Copy link
Member Author

huan commented Jul 12, 2018

Fixed by the latest commit.

@huan huan closed this as completed Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan