-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message.toString format discussion #1676
Comments
Yes, it will be ok and I have no opposition to your change proposal. Please go ahead to submit a PR for you to quickly grasp who has said what at where. |
Thanks a lot. will do it right away. |
Oh, @huan, sorry for a noob question -- I've made the changes locally in my Do I need to trigger a rebuild/recompile or something for the change to take effect? If so, how. Thx a lot! |
change the Message.toString format, ref wechaty#1676
change the Message.toString format, ref #1676
Merged. |
Please help @huan/@windmemory -- I've done the Basically, I'm following @windmemory's excellent tutorial article at: and everything works fine, except that the result still remains the same. Here is my work log:
How to troubleshoot what went wrong? THX! |
Please follow the issue template and describe the reproduce steps and your expect result in detail, or I can not understand what you want to do. Please also open a new issue with your new problem, thanks! |
Alright. Done @ #1681. Thx. |
Would it be OK that the Message.toString format be changed a bit?
https://github.com/Chatie/wechaty/blob/ae371981402b12f9a14c44071fbdde0da72c1836/src/user/message.ts#L227-L237
The current format makes it hard for me to quickly grasp who has said what at where.
I know it is much a personal preference, but would it be OK if I change the output format to
as opposed to,
I can do the fix and submit a PR if there is no strong oppose to the change. Thx.
The text was updated successfully, but these errors were encountered: