Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless param type in example code #1514

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

lijiarui
Copy link
Member

No description provided.

@lijiarui lijiarui changed the title remove useless param type remove useless param type in example code Jul 30, 2018
@huan
Copy link
Member

huan commented Jul 30, 2018

Could you explain why you decide to remove all the typing annotations in the examples code?

@lijiarui
Copy link
Member Author

For a newbie, the will run the example code, and most of them use don't very familiar with ts, when they copy the full example and don't know how to settings, they will get something wrong like the following error:
5541532955122_ pic
5531532955071_ pic

So in order to let a newbie run faster, I think we should remove this. For the developer who is familiar to wechaty, maybe they don't need the example code and can use typescript know what param is what type.

@huan huan merged commit 95503a0 into wechaty:master Jul 30, 2018
@huan
Copy link
Member

huan commented Jul 30, 2018

Thanks for the explanation, it's very reasonable.

Merged.

@lijiarui lijiarui deleted the clean-type branch July 30, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants