Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link for wechaty-puppet-padchat #1836

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Conversation

LinuxSuRen
Copy link
Contributor

@LinuxSuRen LinuxSuRen commented Aug 14, 2019

I'm submitting a...

  • Bug Fix
  • Feature
  • Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Correct a stale link.
wechaty-puppet-padchat is no longer maintain. The new one is wechaty-puppet-padpro.

Does this PR introduce a breaking change?

  • Yes
  • No

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation improvement!

Please follow my review, and also sign the CLA as well.

README.md Outdated Show resolved Hide resolved
@LinuxSuRen LinuxSuRen changed the title WIP Update link for wechaty-puppet-padchat Update link for wechaty-puppet-padchat Aug 14, 2019
@huan
Copy link
Member

huan commented Aug 14, 2019

It's great to see your update.

We will be able to merge this PR after you signed the CLA. Please click the CLA not signed yet button to sign it, thanks!

@LinuxSuRen
Copy link
Contributor Author

Sorry about that. I don't know why I just ignore that.

@huan huan merged commit a532864 into wechaty:master Aug 15, 2019
@huan
Copy link
Member

huan commented Aug 15, 2019

Merged.

Thank you so much for the fix!

And please contact @lijiarui if you would like to join our contributor wechat group: you will be welcome to join if you like. 😄

@LinuxSuRen LinuxSuRen deleted the patch-1 branch August 15, 2019 04:21
@LinuxSuRen
Copy link
Contributor Author

@huan Thanks for the invitation. @lijiarui Please help me to join the group.

@lijiarui
Copy link
Member

@LinuxSuRen Please add my wechat: 13141321843 Thanks!

@LinuxSuRen
Copy link
Contributor Author

Copy that.@lijiarui

@huan
Copy link
Member

huan commented Aug 15, 2019

@LinuxSuRen CQ CQ DE BG1FMO K.

@huan
Copy link
Member

huan commented Aug 15, 2019

@LinuxSuRen
Copy link
Contributor Author

@huan I don't too much about this. Just try to update it. #1838

@lijiarui
Copy link
Member

@LinuxSuRen Could you add my wechat please? And please left a comment when you add my wechat, or I may miss your friend request! Thanks!

@LinuxSuRen
Copy link
Contributor Author

@lijiarui Copy that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants