add magic code for room.say() when @bot happen
#440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijiarui
changed the title
@bot happen
huan
reviewed
Apr 27, 2017
| @@ -184,7 +184,8 @@ export class Room extends EventEmitter implements Sayable { | |||
| const replyToList: Contact[] = [].concat(replyTo as any || []) | |||
|
|
|||
| if (replyToList.length > 0) { | |||
| const mentionList = replyToList.map(c => '@' + c.name()).join(' ') | |||
| const AT_SEPRATOR = String.fromCharCode(8197) | |||
| const mentionList = replyToList.map(c => '@' + c.name()).join(AT_SEPRATOR) | |||
There was a problem hiding this comment.
Don't we need the space to separate the contacts?
const mentionList = replyToList.map(c => '@' + c.name()).join(AT_SEPRATOR + ' ')
There was a problem hiding this comment.
no, we don't need, AT_SEPRATOR equals space.
wechat use special char with unicode code 8197 to indetify real@
by @JasLin
huan
requested review from
JasLin,
dcsan,
xinbenlv,
Gcaufy,
imWildCat,
hailiang-wang and
mukaiu
|
Ok, ic. Please get at least one approvement before I could merge this PR. Thanks! |
Gcaufy
approved these changes
Apr 27, 2017
|
Thanks all for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#362
add m.mentioned() for message, thanks for @JasLin tell us about magic code when @ somebody,
so add maigic code in room.say()