room-join cannot detect inviteeList when people join in the room with qrcode #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
requested changes
Jul 12, 2017
src/puppet-web/firer.ts
Outdated
| @@ -59,9 +59,10 @@ const regexConfig = { | |||
| ], | |||
|
|
|||
| roomJoinQrcode: [ | |||
| /^"(.+)" joined the group chat via the QR Code shared by "?(.+?)".$/, | |||
| /^"(.+)" joined the group chat via "?(.+?)"? shared QR Code.$/, | |||
There was a problem hiding this comment.
Why you get rid of "?(.+?)"?, and use undefined in your code, please explain.
I don't think this change is needed, and also I believe it's not a good choice to do this.
src/puppet-web/firer.ts
Outdated
| @@ -194,7 +195,9 @@ async function checkRoomJoin(m: Message): Promise<void> { | |||
| let inviteeContactList: Contact[] = [] | |||
|
|
|||
| try { | |||
| if (inviter === "You've" || inviter === '你' || inviter === 'your') { | |||
There was a problem hiding this comment.
I'd like to keep this line of code, instead of your new !inviter.
Because I think to check more words in the message is a good way to make sure you are tracing the right message in Wechat.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#248
room-join cannot detect inviteeList when people join in the room with QR code:
If one contact joins in the room by the QR code shared by the bot, system message as follows:
If one contact joins in the room isn't by the QRcode shared by the bot, system message as follows:
(Pay attention that it has more space before 李佳芮)