Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert wechaty-bro.js to plain old javascript syntax #60 #97

Merged
merged 2 commits into from
Nov 17, 2016

Conversation

cherry-geqi
Copy link

When npm start with DEFAULT_HEAD set to "phantomjs", it throws WARN PuppetWebBrowser execute() exception: {"errorMessage":"Unexpected token ','","request"....

After debugging for hours I found that phantomjs, even the latest version, does not know es6 syntax such as arrow function.

Converting to es5 using babeljs.io online tool solves this problem.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.25% when pulling 1bdc761 on cherry-geqi:master into fc8d833 on wechaty:master.

@huan
Copy link
Member

huan commented Nov 16, 2016

Thanks for the contribution!

Could you please keep the original coding style in your Pull Request? Because your PR include too many unrelated code changes.

I use the following styles when developing Wechaty:

  1. comma style first.

    const a = [
        1
      , 2
    ]
  2. semi: never

    const n = 3
  3. align use spaces

      , confFactory:    confFactory
      , contactFactory: contactFactory

After you fixed that, I'm very happy to accept this PR.

Appreciate.

@huan huan changed the title convert wechaty-bro.js to plain old javascript syntax convert wechaty-bro.js to plain old javascript syntax #60 Nov 16, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 54.292% when pulling d46f6d9 on cherry-geqi:master into fc8d833 on wechaty:master.

@huan huan merged commit f0aa292 into wechaty:master Nov 17, 2016
@huan
Copy link
Member

huan commented Nov 17, 2016

Thanks! Coverage also increased, amazing! ;-]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants