From cdcc03aeabfc994d794ce035ea2195f5b7f11d6a Mon Sep 17 00:00:00 2001 From: teknsl Date: Wed, 10 Jul 2024 22:06:50 +0200 Subject: [PATCH 1/5] private browsing support for more browsers * firefox-devedition * firefox-beta * firefox-nightly * qutebrowser --- src/util/IncognitoBrowser.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/util/IncognitoBrowser.cpp b/src/util/IncognitoBrowser.cpp index 77f14160a8b..8b0cddb0998 100644 --- a/src/util/IncognitoBrowser.cpp +++ b/src/util/IncognitoBrowser.cpp @@ -30,6 +30,10 @@ QString getPrivateSwitch(const QString &browserExecutable) {"firefox-esr", "-private-window"}, {"chromium", "-incognito"}, {"brave", "-incognito"}, + {"firefox-devedition", "-private-window"}, + {"firefox-beta", "-private-window"}, + {"firefox-nightly", "-private-window"}, + {"qutebrowser", "--target", "private-window"}, }; // compare case-insensitively From 8e9f88c7205d23cca57ebad1d95f8be06787e636 Mon Sep 17 00:00:00 2001 From: teknsl Date: Thu, 11 Jul 2024 10:04:58 +0200 Subject: [PATCH 2/5] only one argument can be provided --- src/util/IncognitoBrowser.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/IncognitoBrowser.cpp b/src/util/IncognitoBrowser.cpp index 8b0cddb0998..7f60ac2e329 100644 --- a/src/util/IncognitoBrowser.cpp +++ b/src/util/IncognitoBrowser.cpp @@ -33,7 +33,6 @@ QString getPrivateSwitch(const QString &browserExecutable) {"firefox-devedition", "-private-window"}, {"firefox-beta", "-private-window"}, {"firefox-nightly", "-private-window"}, - {"qutebrowser", "--target", "private-window"}, }; // compare case-insensitively From 70b792f63f528e344a6f322bf89a4a3272b5b475 Mon Sep 17 00:00:00 2001 From: teknsl Date: Thu, 11 Jul 2024 10:05:52 +0200 Subject: [PATCH 3/5] firefox developer edition on arch linux --- src/util/IncognitoBrowser.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/IncognitoBrowser.cpp b/src/util/IncognitoBrowser.cpp index 7f60ac2e329..3d147b6f756 100644 --- a/src/util/IncognitoBrowser.cpp +++ b/src/util/IncognitoBrowser.cpp @@ -31,6 +31,7 @@ QString getPrivateSwitch(const QString &browserExecutable) {"chromium", "-incognito"}, {"brave", "-incognito"}, {"firefox-devedition", "-private-window"}, + {"firefox-developer-edition", "-private-window"}, {"firefox-beta", "-private-window"}, {"firefox-nightly", "-private-window"}, }; From 3e6262dc02246820397c0e194031acf615e126b5 Mon Sep 17 00:00:00 2001 From: teknsl Date: Thu, 11 Jul 2024 10:06:50 +0200 Subject: [PATCH 4/5] add to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 83d7c8940c7..a5d91499a39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ - Minor: Added `/warn ` command for mods. This prevents the user from chatting until they acknowledge the warning. (#5474) - Minor: Improve appearance of reply button. (#5491) - Minor: Introduce HTTP API for plugins. (#5383, #5492, #5494) +- Minor: Support more firefox variants for incognito link opening - Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426) - Bugfix: If a network request errors with 200 OK, Qt's error code is now reported instead of the HTTP status. (#5378) - Bugfix: Fixed restricted users usernames not being clickable. (#5405) From 8585cd4246bfcd3ca1306b1252daf010bcbcb9b4 Mon Sep 17 00:00:00 2001 From: Mm2PL Date: Thu, 11 Jul 2024 12:15:44 +0200 Subject: [PATCH 5/5] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a5d91499a39..467c2810eab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ - Minor: Added `/warn ` command for mods. This prevents the user from chatting until they acknowledge the warning. (#5474) - Minor: Improve appearance of reply button. (#5491) - Minor: Introduce HTTP API for plugins. (#5383, #5492, #5494) -- Minor: Support more firefox variants for incognito link opening +- Minor: Support more Firefox variants for incognito link opening. (#5503) - Bugfix: Fixed tab move animation occasionally failing to start after closing a tab. (#5426) - Bugfix: If a network request errors with 200 OK, Qt's error code is now reported instead of the HTTP status. (#5378) - Bugfix: Fixed restricted users usernames not being clickable. (#5405)