Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feedback from scs engine #228

Merged
merged 18 commits into from
Apr 2, 2024
Merged

feat: feedback from scs engine #228

merged 18 commits into from
Apr 2, 2024

Conversation

baruchiro
Copy link
Contributor

This pull request fixes the regex pattern in the check_new_rules.go file to include commented rules.

It also updates the authenticated_url.go file to ignore variable in passwords.

Copy link

github-actions bot commented Mar 26, 2024

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 8
Files parsed placeholder 8
Files failed to scan placeholder 0
Total executed queries placeholder 52
Queries failed to execute placeholder 0
Execution time placeholder 1

@baruchiro baruchiro marked this pull request as draft March 26, 2024 09:31
@baruchiro baruchiro changed the title ignore auth-url with password vairable feat: feedback from scs engine Apr 1, 2024
@baruchiro baruchiro marked this pull request as ready for review April 2, 2024 12:11
@baruchiro baruchiro merged commit b77600c into master Apr 2, 2024
7 of 8 checks passed
@baruchiro baruchiro deleted the scs branch April 2, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant