From 9ff82b0395e7eaf073433361b30377fd831ac47b Mon Sep 17 00:00:00 2001 From: delimaneto <167232526+delimaneto@users.noreply.github.com> Date: Fri, 10 May 2024 10:32:43 -0300 Subject: [PATCH] Add Suport for `google_secret_manager_secret_version` to TGC (#10652) --- mmv1/templates/tgc/resource_converters.go.erb | 1 + ...mple_secret_manager_secret_iam_policy.json | 21 ++++++++++++++++++- ...xample_secret_manager_secret_iam_policy.tf | 6 ++++++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/mmv1/templates/tgc/resource_converters.go.erb b/mmv1/templates/tgc/resource_converters.go.erb index c486ac04f463..c70484cc02d2 100644 --- a/mmv1/templates/tgc/resource_converters.go.erb +++ b/mmv1/templates/tgc/resource_converters.go.erb @@ -79,6 +79,7 @@ func ResourceConverters() map[string][]cai.ResourceConverter { "google_spanner_instance_iam_binding": {spanner.ResourceConverterSpannerInstanceIamBinding()}, "google_spanner_instance_iam_member": {spanner.ResourceConverterSpannerInstanceIamMember()}, "google_project_service": {resourceConverterServiceUsage()}, + "google_secret_manager_secret_version": {secretmanager.ResourceConverterSecretManagerSecretVersion()}, "google_pubsub_lite_reservation": {pubsublite.ResourceConverterPubsubLiteReservation()}, "google_pubsub_lite_subscription": {pubsublite.ResourceConverterPubsubLiteSubscription()}, "google_pubsub_lite_topic": {pubsublite.ResourceConverterPubsubLiteTopic()}, diff --git a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json index 73264a0def65..03984d97d6a4 100644 --- a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json +++ b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.json @@ -13,5 +13,24 @@ } ] } + }, + { + "name": "//secretmanager.googleapis.com/placeholder-rywlkkLJ", + "asset_type": "secretmanager.googleapis.com/SecretVersion", + "ancestry_path": "{{.Ancestry}}/project/{{.Provider.project}}", + "resource": { + "version": "v1", + "discovery_document_uri": "https://www.googleapis.com/discovery/v1/apis/secretmanager/v1/rest", + "discovery_name": "SecretVersion", + "parent": "//cloudresourcemanager.googleapis.com/projects/{{.Provider.project}}", + "data": { + "payload": { + "data": "c2VjcmV0LWRhdGE=" + } + } + }, + "ancestors": [ + "organizations/{{.OrgID}}" + ] } -] +] \ No newline at end of file diff --git a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf index 16af8bdff628..badd7f7b3e39 100644 --- a/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf +++ b/mmv1/third_party/tgc/tests/data/example_secret_manager_secret_iam_policy.tf @@ -46,6 +46,12 @@ resource "google_secret_manager_secret" "secret-basic" { } } +resource "google_secret_manager_secret_version" "secret-version-basic" { + secret = google_secret_manager_secret.secret-basic.id + + secret_data = "secret-data" +} + resource "google_secret_manager_secret_iam_policy" "policy" { project = google_secret_manager_secret.secret-basic.project secret_id = google_secret_manager_secret.secret-basic.secret_id