-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 7.2 #27
Conversation
That easy, huh. Will give it a spin locally to see. Looks like it compiles correctly on Actions which is always a good sign 😄 |
I was quite surprised myself, 7.2 has seemed to be a much easier version for updating. Thankfully the project never implemented its own Groovy classes for building. Which is where I've ran into major pains when updating projects. |
Sorry for the delay! Was able to deploy a test, 1.22.1-SNAPSHOT, to my repo. Can try testing with this for a bit to make sure all is well but I'd bet it is. |
No problem, just ran a test on a bot using the shapshot, have not ran into any issues. Thanks for the update |
Also wanted to check, since this is a version update PR, what's your opinion on updating the JDA dependency version to use |
We already use 4.3.0 per https://github.com/Chew/JDA-Chewtils/blob/master/build.gradle#L39 I suppose I could fix the deprecations since it's up to date now, but out of the scope of this PR. |
Forgot to push these, had been sitting on local repo.
Pull Request
Pull Request Checklist
Please follow the following steps before opening this PR.
PRs that do not complete the checklist will be subject to denial for
missing information.
or merged features/bug fixes.
Pull Request Information
Check and fill in the blanks for all that apply:
______
module of the JDA-Utilities library.______
.Description
Updated Gradle to 7.2 - A test with a local bot instance was done. All subprojects ran successful builds and everything in the bot worked as well.