[CHIA-307] (long-lived) Vault #16610
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Added
github-actions
bot
added
the
merge_conflict
github-actions
bot
added
merge_conflict
…ult_from_main_368fecc17eb902551d21fad4e39b0f26befbbe67
…fad4e39b0f26befbbe67' into quex.allow_only_pks
Source hash: 368fecc Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/d03844c53ef64468bd4590437a56f578cec08111.html
github-actions
bot
removed
the
merge_conflict
This adds support for entries in the keyring that have no secret information associated with them. This is perhaps a silly choice to keep in the keyring since it is public information but since the keyring is the standard area where we manage keys right now it seems like the logical choice at least in the short term.
github-actions
bot
added
the
merge_conflict
Source hash: 0a76e22 Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/d91768ba0474d2b51f5e409bff78c7e34f658e6b.html
This PR attempts to remove the `PrivateKey` type from the wallet insofar as is possible. The object is to be able to use any type of private key with the wallet's `.private_key` member variable.
…secp_to_key_types
…and finish TXs (#18476) While doing some other work, I noticed that the Vault's `gather_signing_info` method was a little bit rigid in what it would sign. It would only sign one single vault spend in a bundle that it saw, and it would also assume that every vault spend that it saw needed to be signed. This PR makes sure it only attempts to sign vaults that have a p2_delegated_secp puzzle inside and also allows it to sign multiple at once.
This PR makes the vault recovery endpoint return the specific IDs of the two transactions it's creating instead of simply returning a list and expecting the user to understand the order. There's also a minor change to `@tx_endpoint` to support this.
…long_lived_vault_from_main_483ec60771304798ce7187e81a361fc1d3e7225d
Remaining commits: 0 Source hash: 483ec60 Merge diffs: https://quexington.github.io/merge-diffs/ffda305ac880ed8495dc3b7786438235155c1c4c.html
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: pypi/types-cryptography@3.3.23.2) |
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
…long_lived_vault_from_main_2b3999ddedaca53f28d0c474badb588e9d70e0be
Source hash: 2b3999d Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/cb7f7e64c9594b3831fc6dd4520be63e56021fb8.html
…long_lived_vault_from_main_95592957254f8c548f189d70c8a36b1a55f327f2
Remaining commits: 0 Source hash: 9559295 Merge diffs: https://quexington.github.io/merge-diffs/b680f456fbe3ea8dcd8a54e4e15c0734478d1486.html
With the advent of vaults, in order to preserve existing UX where the wallet can perform all actions by itself, you need a secp private key available to the wallet. In order to store these private keys in the keychain, this PR generalizes the keychain code to support keys of any type.
…long_lived_vault_from_main_1b4b8e8df517cb38d1637c54444ba3ab12286624
Source hash: 1b4b8e8 Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/c9d6ac67561a971299ac61faf6b46560fd9b16f7.html
…long_lived_vault_from_main_111b0e57d5995d760cac877c45ef8822506800b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
if vaultand try to eliminate them