Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-504] Add support for external signers (PLEASE SQUASH) #18199

Merged
merged 417 commits into from
Jun 26, 2024

Conversation

Quexington
Copy link
Contributor

This is a "catchup" from long_lived/vault containing all of the features necesary to support external signers according to CHIPs 27-31. The RPC support was already in place, but this pipes that functionality through to the command line and allows the wallet to act as a signer for transactions generated by other, potentially observer wallets.

It's important to squash this PR because I made a series of [UNDO] commits on top of the history of long_lived/vault in order to separate out the changes I didn't want. In this way the long_lived process hopefully has more weight than when I squashed a bit of it preemptively in an earlier "catchup". If this PR is not squashed when it's merged, then the next catchup to the vault branch will essentially eliminate its diff because there are later changes that undo stuff that has already been done.

The following PRs into long_lived/vault are included:

…3e3b630fbd507c607fe7' into quex.signer_protocol
@Quexington Quexington marked this pull request as ready for review June 18, 2024 16:38
@Quexington Quexington requested a review from a team as a code owner June 18, 2024 16:38
@github-actions github-actions bot added coverage-diff merge_conflict Branch has conflicts that prevent merge to main labels Jun 18, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 18, 2024
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 18, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 18, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 20, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 20, 2024
@Quexington Quexington closed this Jun 24, 2024
@Quexington Quexington reopened this Jun 24, 2024
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 24, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 25, 2024
@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 25, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 25, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 25, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jun 25, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/coin_funcs.py 52.6% lines 135, 138, 164, 167, 180, 210, 216, 219, 233
chia/cmds/dao_funcs.py 81.2% lines 158-160, 303-305, 338-340, 371-372, 374, 402-404, 434-436
chia/cmds/wallet.py 94.4% lines 847, 856
chia/cmds/wallet_funcs.py 79.8% lines 286, 292, 301, 304, 345, 716, 795, 939, 1009, 1035, 1069, 1174, 1222, 1256, 1510, 1513, 1653, 1657, 1729
chia/rpc/wallet_rpc_api.py 66.7% lines 390, 766
chia/wallet/util/clvm_streamable.py 95.8% lines 178, 186
chia/wallet/wallet_state_manager.py 75.0% lines 382, 384
Total Missing Coverage
1250 lines 54 lines 95%

@Starttoaster
Copy link
Contributor

This PR is waiting on an override of the coverage diff.

@markelrod
Copy link
Contributor

coverage exceptions are fine

@Starttoaster Starttoaster merged commit c25eeb0 into main Jun 26, 2024
370 of 371 checks passed
@Starttoaster Starttoaster deleted the quex.external_signers branch June 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants