Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maybe re-enable wallet ignore block validation autouse fixture #18215

Merged
merged 1 commit into from
Aug 21, 2024
Merged

maybe re-enable wallet ignore block validation autouse fixture #18215

merged 1 commit into from
Aug 21, 2024

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Tests Changes to tests labels Jun 20, 2024
@altendky altendky closed this Jun 25, 2024
@altendky altendky reopened this Jun 25, 2024
@altendky altendky marked this pull request as ready for review June 27, 2024 17:24
@altendky altendky requested a review from a team as a code owner June 27, 2024 17:24
@altendky altendky marked this pull request as draft June 27, 2024 17:42
@github-actions GitHub Actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Aug 12, 2024
arvidn
arvidn approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue where we get a lot of warnings saying that this fixture is not awaited.

@altendky altendky marked this pull request as ready for review August 21, 2024 17:43
@pmaslana pmaslana merged commit 5376d9e into main Aug 21, 2024
703 of 712 checks passed
@pmaslana pmaslana deleted the wallet_ignore_block_validation_fix branch August 21, 2024 18:03
@altendky altendky mentioned this pull request Sep 3, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog stale-pr Flagged as stale and in need of manual review Tests Changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @arvidn @pmaslana