Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PrivateKey type from wallet (to some extent) #18228

Closed
wants to merge 50 commits into from

Conversation

Quexington
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

emlowe and others added 8 commits June 17, 2024 17:40
* update GUI pin to electron 30.0.9 55cdd0351eec1e7da8977d31b09c0e4d5a1f7a79

* Update GUI pin to merged commit hash for 30.0.9
* 2.4.0 changelog

* minor update

* minor updates
…nt/main_from_release_2.4.0_786cb31fda9541a64628f9b0f5535f6bfc4ffc9e
* correct gh release upload casing of macos torrent file

(cherry picked from commit 310dbdd)

* correct s3 upload case
…htProof" #17738 (#18231)

Revert "use rust types for RecentChainData, ProofBlockHeader and WeightProof …"

This reverts commit 3f0d5c0.
* Update CHANGELOG for 2.4.1

* Update some other items int he changelog

* Revert "Update some other items int he changelog"

This reverts commit 047b816.

* changelog updates
* Update CHANGELOG for 2.4.1

* Update some other items int he changelog

* Revert "Update some other items int he changelog"

This reverts commit 047b816.

* changelog updates

* Add 12-word mnemonic known issue

* Update 12-word issue
@Quexington Quexington added 1.6.0 Added Required label for PR that categorizes merge commit message as "Added" for changelog and removed 1.6.0 labels Jun 25, 2024
@Quexington Quexington force-pushed the quex.remove_sk_type branch 2 times, most recently from a6ca44e to 866af87 Compare June 26, 2024 15:23
altendky and others added 16 commits June 28, 2024 07:42
…nt/main_from_release_2.4.0_4ce568b129899591bdb26e5fcba7d16785054646
adding ca updates

Co-authored-by: ChiaAutomation <automation@chia.net>
Simplify add_to_pool around DB operations.
…#18255)

Simplify get_items_by_coin_id and make it return an iterator.
#18242)

Properly order HARD_FORK_2_0 and SOFT_FORK_4 in ConsensusMode.
* Send different uncompact buckets to blueboxes.

* Lint.

* Add sleep interval before continue
* [CHIA-883] Fix duplicate connection log spam.

* Add old condition too as a safety margin.
the hard fork has activated. From now on we can simplify some of the updated consensus rules to apply unconditionally to block height
make MempoolItem and InternalMempoolItem contain the SpendBundleConditions directly, rather than the NPCResult. A mempool item is guaranteed to be valid, so the error state of NPCResult will never be engaged anyway.
…nt/main_from_release_2.4.1_7c54e60910c6db80c2a7d92ed4f2d500e8e7179c
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 8, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jul 8, 2024
Starttoaster and others added 25 commits July 8, 2024 20:29
…nt/main_from_release_2.4.1_4b2f9f0c7e7e575dd266c238a017b9856b254a1f
Drop unknown tables when resetting wallet sync DB
…nt/main_from_release_2.4.1_406550e4ccd1b3d683d58b537f1cab3a307a4b54
remove the original form block compression, now that the hard fork has activated and we serialize CLVM in a more efficient way
…#18275)

* `.get_passphrase` -> `.keyring.get_key()`

* `.set_password` -> `.keyring.set_key`

* `.delete_passphrase` -> `.keyring.delete_key`

* `.*_label` -> `.keyring.*_label`

* Introduce DecryptedKeyringData

* Fix bad assumption

* Fix tests

* Pre-commit

* Pivot key storage to external metadata for forwards compatibility

* typo & passphrase -> key
…nt/main_from_release_2.4.1_4572390f40fce50ba186f13ae30b171887e3a104
…long_lived_vault_from_main_a959a125003716b1765207a62fd93e7c782b422b
* preliminary setup with poetry

* don't worry about locking the poetry env for the exploration right now

* recover black config in pyproject.toml

* install.sh for linting workflow

* pull chiavdf version from poetry in install-timelord.sh

* activate etc in upload and lint workflow

* debug poetry show output on macos

* update to clvm-tools 0.4.4

* add back setproctitle

* catchup deps

* lock

* allow 3.10

* debug

* make Install.ps1 use poetry as well

* -ErrorAction Ignore

* more todo about python version selection

* make install-timelord.sh modifications more posix compliant

* gitignore .penv* and .venv* as well

* remove requirements.penv.txt

* get artifact check requirements from poetry

* fix .gitignore for venv symlink

* separate out poetry setup

* :

* comment out code to be worked on

* setup poetry for dependency check

* ignore new poetry symlink

* chia_rs==0.1.4

* a few updates

* some missed updates `:[`

* update some types libs

* fix extras

* activate

* just use `python` somewhere

* for windows

* less symlinking for windows

* oops

* s

* more

* # shellcheck disable=SC2086

* activate action

* more python version

* lock up

* include ipython (for python >=3.8)

* add miniupnpc extra

* add poetry-dynamic-versioning

* type it out

* better match dev versioning

* catch up and delete setup.py again

* lock

* add pytest-cov

* .penv/bin/poetry

* .venv for windows activation

* update pytest-xdist

* install upnp extra

* upnp

* quote

* maybe update some deps

* mandatory and string

* oops

* slighty tidy

* debug pip list

* debug

* pybind11 maybe instead?

* remove pip install debugging

* debug without upnp nor pypi.chia.net

* chiavdf==1.0.8

* bring back upnp

* re-enable upnp

* diagnostic exception reraise

* .exe?

* diagnostics

* .cmd...?

* light tidy

* more cleanup

* make dependency check script not cwd dependent for finding the poetry env

* correct sh substitution

* lock

* coverage 7

* todo cleanup

* poetry update

* interesting

* windows too

* support non-editable install via scripts again

* oops

* again

* sheesh

* fixup

* more

* more

* Update dependencies

* various pre-commit linter updates

* add pyupgrade to extras list

* use priority=supplemental instead of secondary

* Add in some missing deps

* update setuptools and pyinstaller to match main

* venv->.venv

* lint fixes

* update a few packages for 3.12 support

* get zstd from chia resource for python 3.12

* Adjustments to dynamic versioning

* experiments with versioning

* test fixes

Signed-off-by: Earle Lowe <e.lowe@chia.net>

* fixup last commit

* include upnp as extra when installing on windows

* include mozilla-ca as a package for the cacert.pem file

* some windows tweaks

* use SPECPATH as anchor path in pyinstaller.spec file

* Add lxml as dev dependency

* Fixup typo in lxml version

* Update some packages to resolve GH vuln reports

* Update more packages to resolve GH vulns

* Ignore pylint license in depedency checker

* match installation of the dynamic version plugin on windows

* Fix issues with setting windows environment and use pip to install plugin per poetry docs recommendation

* properly apply non-editable option with -i

* use -f with ln to remove existing file as needed

* use shell=true for subprocess to help windows run chia if it's a .cmd

* Update .coveragerc

* use shutil.which() to find chia executable in a cross platform way

* mypy fixes

* Address conflicts for numpy based on python version

* Update lock file

* Remove troublesome reference to pypi source

* Add TODOs for manual install of poetry-dynamic-versioning plugin

* Use poetry dynamic versioning to figure out the version rather than setuptools_scm

* Update .github/workflows/reflow-version.yml

Co-authored-by: Kyle Altendorf <sda@fstab.net>

* Update .github/workflows/test-single.yml

Co-authored-by: Kyle Altendorf <sda@fstab.net>

* Update urllib3

* Attempts to get dynamic versioning to output something semver

* more versioning finangling

* lint pyproject.toml

* Update certifi

---------

Signed-off-by: Earle Lowe <e.lowe@chia.net>
Co-authored-by: Earle Lowe <e.lowe@chia.net>
Co-authored-by: Earle Lowe <30607889+emlowe@users.noreply.github.com>
…ult_from_main_a959a125003716b1765207a62fd93e7c782b422b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants