Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root hash, does None mean empty or unspecified? #18244

Merged
merged 7 commits into from
Jul 11, 2024
Merged

root hash, does None mean empty or unspecified? #18244

merged 7 commits into from
Jul 11, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jun 25, 2024 •
edited
Loading

Purpose:

The intent is to keep interfaces (RPC and CLI) unchanged at present. Inside of those we introduce the Unspecified class and a single instance of it to represent, well, an unspecified root. None is now used to represent the root of an empty tree.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jun 25, 2024
fchirica
fchirica previously approved these changes Jun 25, 2024
View reviewed changes
@altendky altendky requested review from fchirica and emlowe June 28, 2024 19:39
@altendky altendky marked this pull request as ready for review July 11, 2024 15:31
@altendky altendky requested a review from a team as a code owner July 11, 2024 15:31
@altendky altendky closed this Jul 11, 2024
@altendky altendky reopened this Jul 11, 2024
@Starttoaster
Copy link
Contributor

When this has passing CI, it will also require a coverage diff override it looks like.

@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/data_layer_util.py 85.7% lines 339
chia/rpc/data_layer_rpc_api.py 94.4% lines 170
Total Missing Coverage
44 lines 2 lines 95%

@Starttoaster Starttoaster merged commit cf7b549 into main Jul 11, 2024
730 of 732 checks passed
@Starttoaster Starttoaster deleted the root_hash_none_empty_or_unspecified branch July 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@fchirica fchirica Awaiting requested review from fchirica

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @Starttoaster @fchirica @emlowe