CHIA-818 Add Soft Fork options to simulator config #18247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack60612
force-pushed
the
jn.sim-softfork
branch
from
396b3cf
to
a47db8d
Compare
|
i added the commit label |
jack60612
added
Added
jack60612
changed the title
arvidn
approved these changes
Jul 8, 2024
|
I don't believe this affects the simulations that are run as part of the full node tests, right? |
it does not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Allow user to set simulator fork block height
Current Behavior:
No forks active on simulator (copy main net values, way too high for sim)
New Behavior:
All forks active by default (block height zero)
Testing Notes:
Not sure if needed, as existing consensus code is used. This just adds a shortcut to enable the forks on the simulator.