Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility for add_private_key (cherrypick from main) #18256

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jun 26, 2024

cherrypick from main PR 18237 for the add_private_key fix

This was suggested by Bill for inclusion into 2.4.2

* Fix backwards compatibility for `add_private_key`

* Another backwards compatibility fix
@emlowe emlowe requested a review from a team as a code owner June 26, 2024 16:56
@emlowe emlowe requested a review from Quexington June 26, 2024 16:57
@emlowe emlowe added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 26, 2024
@emlowe
Copy link
Contributor Author

emlowe commented Jun 27, 2024

Close and re-open for macos 12 ci

@emlowe emlowe closed this Jun 27, 2024
@emlowe emlowe reopened this Jun 27, 2024
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@pmaslana pmaslana merged commit 0970ba7 into release/2.4.2 Jun 28, 2024
992 checks passed
@pmaslana pmaslana deleted the EL.cherry-18237 branch June 28, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants