catchup: long_lived/vault from main @ 9e1a4dceb724d7ebf56e3d8a75e8692184997805 #18258

Quexington · 2024-06-26T18:07:21Z

Source hash: 9e1a4dc
Remaining commits: 0
Merge diffs: https://quexington.github.io/merge-diffs/844cb8ea94ce7f419c3d26ba471f747de021784f.html

* Updated GUI submodule ref * Aligned `lerna` and `nx` versions * Ignored .nx/cache * Applied `npm audit fix` * Updated `npm_windows/package-lock.json` * Updated `npm_linux/package-lock.json`

Annotate test_trades.py.

…nt/main_from_release_2.4.0_1e677831c11c99e927de97b01e59996e1a6cc08c

Annotate chia_and_cat_for_something.

Source hash: 1e67783 Remaining commits: 0

* extend test_full_node * bump chia_rs dependency to 0.10.0 * initialize new AGG_SIG_*_ADDITIONAL_DATA fields in ConsensusConstants. Increase end-to-end test coverage of validating message suffixes as it's moving to condition parsing * remove validaton from pkm_pairs * NO_RELATIVE_CONDITIONS_ON_EPHEMERAL is always enabled in chia_rs 0.10.0 * Update chia/_tests/core/full_node/test_conditions.py Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org> --------- Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>

Update dependabot

…#18152) * Use TYPE_CHECKING to work around python 3.8 limitations with generics * Add comment about 3.8 specific workaround

* CHIA-752 - set permissions in postinst.sh for chrome-sandbox * Add check for permissions of chrome-sandbox * one-liner permissions check * prettier fix * Update build-linux-installer-deb.yml

…nt/main_from_release_2.4.0_2fe28180762ac7f3cb49d54d6b40e3245862b4e1

Source hash: 2fe2818 Remaining commits: 1

…nt/main_from_release_2.4.0_866493af56d7ddf45eb185eb2950aaf8149d47de

) Co-authored-by: Mark Elrod <elrod@shallowpool.com>

Source hash: 866493a Remaining commits: 0

Remove chia.clvm.singleton

…nt/main_from_release_2.4.0_8893f13d075adc150e4ee4511f85b359533f9cc0

@altendky

* Add the concept of 'action scopes' * pylint and test coverage * add try/finally * Address comments by @altendky * Address comments by @altendky * 86 memos * Only one callback * pylint * Address more comments by @altendky * remove unused variable * add comment

* Move VersionedBlob to chia.util.streamable * Move format_bytes to chia.cmds.cmds_util * Move format_minutes to chia.cmds.cmds_util * Move prompt_yes_no to chia.cmds.cmds_util * Move get_list_or_len to from chia.plot_sync.receiver * Move validate_directory_writable to chia.cmds.cmds_util * Move *termination_signals to test_services * Move UInt*Range to chia.util.streamable * Create chia.util.batches * Create chia.server.signal_handlers * Create chia._tests.util.split_managers * Move ValuedEvent to chia.types.transaction_queue_entry * Move available_logical_cores to chia.util.cpu * Move caller_file_and_line to chia._tests.util.misc * Move satisfies_hint to chia._tests.wallet.test_singleton_lifecycle_fast

Source hash: 8893f13 Remaining commits: 0

* avoid interpolating values into sql queries * Update data_store.py

* Removed `lerna` from build_scripts * Fixed an issue where `electron-builder` in unexpected path was executed * Fixed lint errors * Use foreground-scripts with initial npm ci to see if it resolves strange mac dlopen problemFixed lint errors * Removed `--foreground-scripts` from `npm ci`

* add install action editable option test * fixup * job name * shooby-doowah

…8137)

remove coroutine never awaited warning ignore

* Revert "Revert "CHIA-414 fixup datalayer benchmark" (#18054)" This reverts commit b49eb0a. * repeats * report coefficients * hardcode timeout * 5 * no benchmarks * 0.6 * repeat name * format_number() * higher limits * 10x * tidy

Annotate test_mempool.py.

Add the ability to set a fee in make_item.

* fix for freebsd suggested by user alghmma * fix copy paste

Deduplicate sb mempool asserts.

* Add the concept of 'action scopes' * Add `WalletActionScope` * Add the concept of 'action scopes' * pylint and test coverage * add try/finally * add try/except * Undo giving a variable a name * Test coverage * Ban partial sigining in another scenario * Make WalletActionScope an alias instead * Add extra_spends to the action scope flow * Add test for .add_pending_transactions

* Fix backwards compatibility for `add_private_key` * Another backwards compatibility fix

…es and bytes32 (#15718)

… test_agg_sig_illegal_suffix (#18235) Cover AGG_SIG_ME_ADDITIONAL_DATA in message construction for test_agg_sig_illegal_suffix.

@altendky

* Repin hsms * Add to sdist only allowed list * Signer protocol tweaks * Convert wallet RPC client to deserialized types * Introduce @tx_out_cmd decorator * Make execute_signing_instructions RPC * Add transport layer support * Add signer commands * Rework wallet execute_signing_instructions * Inadvertent merge changes * Fix signer command tests * Try a different approach: recursive flattening * Bump hsms * Add comments * Test coverage * Coverage ignores * Remove inadvertent time traveler * Bring in lost time traveler * pylint * Attempt to make qr test less flaky * Actually test coverage ignore * Small refactor for test coverage * transport -> translation * missed one * transport -> translation * Fix asdict error * coverage * Forgoe rotation testing for now * Test coverage * jsonify_unsigned_txs -> full_jsonify * Move a class * Add better type checking to framework * explicitly state kwargs on _CommandParsingStage Co-authored-by: Kyle Altendorf <sda@fstab.net> * Address comments by @altendky * Consolidate add_private_key and add_public_key * Consolidate get_key_for_fingerprint and get_public_key_for_fingerprint * Test fix * Merge fix * Bad merge * Bad merge * oops * pylint * Tweak keychain_proxy.get_key_for_fingerprint * Fix wallet RPC test? * pragma: no cover * Redesign clvm_streamable * Fix test imports * black * fix one more test * Address comments by @altendky * Test coverage * bytes32 * Better CLI mnemonic check * Use functools.partial * Rename full jsonify to chip 29 * whoops missed a couple * Better CLI mnemonic check * black * pylint * Missed one * black * Farm at least one block * Revert last change and fix 0 block farming * black * bad merge * Merge fix * Inadvertent changes * Inadvertent changes * Syncronize with quex.tx_out_decorator2 * These are no longer dictionaries. * Use new clvm_streamable pattern * Fix offer endpoint * Add @tx_out_cmd decorator * Bump ecdsa version * Fix @marshal util to return proper transactions * Add get_public_key * port `chia wallet send` to @tx_out_cmd * merge fix of puzzle hash derivation * Port `chia wallet coins` to @tx_out_cmd * Port chia wallet clawback to @tx_out_cmd * Port `chia wallet take/cancel_offer` to @tx_out_cmd * Port `chia wallet did ...` to @tx_out_cmd * Port `chia wallet nft ...` to @tx_out_cmd * Port `chia wallet notifications send` to @tx_out_cmd * Port `chia wallet vcs ...` to @tx_out_cmd * Port `chia dao ...` to @tx_out_cmd * Exclude data layer and plotnft functions * [no ci] * Address comments by @AmineKhaldi * Fix rpc util * add test for BSTLSigningInstructions * [UNDO] d9c6f54 * [UNDO] 7fc1d2a * [UNDO] 23c9ee8 * [UNDO] aacc9f0 * [UNDO] 5484654 * Undo unintentional changes * Stuff that's not part of this * More stuff that doesn't belong * One last thing that doesn't belong * Unintentional change --------- Co-authored-by: Kyle Altendorf <sda@fstab.net> Co-authored-by: Amine Khaldi <amine.khaldi@reactos.org>

* Optimize min height leaf. * Lint. * Lint. * Add tests. * Lint. * Lint. * Parametrize test. * Lint. * Update chia/data_layer/data_store.py Co-authored-by: Kyle Altendorf <sda@fstab.net> * Address review comments. * Report all hashes. --------- Co-authored-by: Kyle Altendorf <sda@fstab.net>

…long_lived_vault_from_main_9e1a4dceb724d7ebf56e3d8a75e8692184997805

socket-security · 2024-06-26T18:08:00Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/lerna@7.1.3, npm/lerna@7.1.4, npm/lerna@8.1.3, npm/nx@16.3.2

View full report↗︎

github-actions · 2024-06-27T14:29:04Z

File	Coverage	Missing Lines
`chia/_tests/util/key_tool.py`	0.0%	lines 25
`chia/_tests/util/misc.py`	86.7%	lines 684-685
`chia/_tests/util/test_action_scope.py`	98.8%	lines 133
`chia/_tests/wallet/sync/test_wallet_sync.py`	50.0%	lines 1483-1484
`chia/_tests/wallet/test_singleton_lifecycle_fast.py`	74.1%	lines 64-66, 68, 175, 193, 210
`chia/cmds/cmds_util.py`	98.6%	lines 139
`chia/cmds/coin_funcs.py`	75.0%	lines 106, 108
`chia/cmds/dao_funcs.py`	81.8%	lines 158, 303, 338, 371, 402, 434
`chia/cmds/data_funcs.py`	18.2%	lines 45, 58, 179, 190, 201, 212, 242, 300, 328
`chia/cmds/netspace_funcs.py`	0.0%	lines 5
`chia/cmds/param_types.py`	96.3%	lines 74, 80-81, 125-126
`chia/cmds/plotnft_funcs.py`	0.0%	lines 20, 30, 37, 237, 327, 344, 355, 358
`chia/cmds/rpc.py`	0.0%	lines 113
`chia/cmds/wallet_funcs.py`	85.5%	lines 297, 301, 303-304, 685, 1454, 1484, 1656
`chia/daemon/server.py`	50.0%	lines 63
`chia/data_layer/data_layer_server.py`	0.0%	lines 16
`chia/plotting/check_plots.py`	0.0%	lines 26
`chia/rpc/rpc_server.py`	0.0%	lines 367
`chia/server/signal_handlers.py`	88.9%	lines 88, 95-96, 98-99
`chia/types/coin_spend.py`	0.0%	lines 34, 40
`chia/util/action_scope.py`	98.9%	lines 37
`chia/util/profiler.py`	0.0%	lines 30, 41-42, 62, 128, 130, 132, 134, 138, 164
`chia/util/timing.py`	0.0%	lines 28-31
`chia/wallet/puzzles/load_clvm.py`	0.0%	lines 58-59, 62

Total	Missing	Coverage
1892 lines	83 lines	95%

markelrod

coverage exceptions are fine

ChiaMineJP and others added 30 commits June 9, 2024 00:27

Aligned lerna and nx versions (#18121)

1e67783

* Updated GUI submodule ref * Aligned `lerna` and `nx` versions * Ignored .nx/cache * Applied `npm audit fix` * Updated `npm_windows/package-lock.json` * Updated `npm_linux/package-lock.json`

CHIA-619 Annotate test_trades.py (#17447)

387619b

Annotate test_trades.py.

Merge commit '1e677831c11c99e927de97b01e59996e1a6cc08c' into checkpoi…

3fee057

…nt/main_from_release_2.4.0_1e677831c11c99e927de97b01e59996e1a6cc08c

[CHIA-740] Annotate chia_and_cat_for_something (#18145)

7b08caa

Annotate chia_and_cat_for_something.

checkpoint: into main from release/2.4.0 @ 1e67783 (#18147)

78da8ac

Source hash: 1e67783 Remaining commits: 0

Update Managed Files (#18149)

f8bfd63

Update dependabot

Use TYPE_CHECKING to work around python 3.8 limitations with generics (…

2fe2818

…#18152) * Use TYPE_CHECKING to work around python 3.8 limitations with generics * Add comment about 3.8 specific workaround

minor fix for make_spend function (#18131)

a5be6eb

pylint disable contextmanager-generator-missing-cleanup (#18139)

15a9a16

CHIA-752 - set permissions in postinst.sh for chrome-sandbox (#18164)

866493a

* CHIA-752 - set permissions in postinst.sh for chrome-sandbox * Add check for permissions of chrome-sandbox * one-liner permissions check * prettier fix * Update build-linux-installer-deb.yml

Merge commit '2fe28180762ac7f3cb49d54d6b40e3245862b4e1' into checkpoi…

e12f1e5

…nt/main_from_release_2.4.0_2fe28180762ac7f3cb49d54d6b40e3245862b4e1

checkpoint: into main from release/2.4.0 @ 2fe2818 (#18182)

7353bf5

Source hash: 2fe2818 Remaining commits: 1

Merge commit '866493af56d7ddf45eb185eb2950aaf8149d47de' into checkpoi…

27ce713

…nt/main_from_release_2.4.0_866493af56d7ddf45eb185eb2950aaf8149d47de

updated gui to 5d6442180f9ddfda756c0c89de5ed56f2f225f06 (#18183)

9d8edc5

updated gui to 5d6442180f9ddfda756c0c89de5ed56f2f225f06 (#18183) (#18187

8893f13

) Co-authored-by: Mark Elrod <elrod@shallowpool.com>

checkpoint: into main from release/2.4.0 @ 866493a (#18185)

84623ce

Source hash: 866493a Remaining commits: 0

Remove chia.clvm.singleton (#18163)

a6fca99

Remove chia.clvm.singleton

Merge commit '8893f13d075adc150e4ee4511f85b359533f9cc0' into checkpoi…

b6fd575

…nt/main_from_release_2.4.0_8893f13d075adc150e4ee4511f85b359533f9cc0

checkpoint: into main from release/2.4.0 @ 8893f13 (#18198)

51cc569

Source hash: 8893f13 Remaining commits: 0

avoid interpolating values into sql queries (#18181)

a9dfc75

* avoid interpolating values into sql queries * Update data_store.py

add install action editable option test (#18168)

570d616

* add install action editable option test * fixup * job name * shooby-doowah

remove some pylint ignores (#18140)

3061cd8

remove unused tree_id parameter from DataStore.batch_upsert() (#1…

74b86c0

…8137)

CHIA-420 remove coroutine never awaited warning ignore (#18113)

60ae4bc

remove coroutine never awaited warning ignore

CHIA-617 Annotate test_mempool.py (#18136)

750b6de

Annotate test_mempool.py.

AmineKhaldi and others added 11 commits June 24, 2024 13:54

CHIA-765 Add the ability to set a fee in make_item (#18174)

9abedb5

Add the ability to set a fee in make_item.

Fix for freebsd suggested by user alghmma (#17994)

7a8489e

* fix for freebsd suggested by user alghmma * fix copy paste

remove no-op semver action from rpm build (#18224)

a958f80

CHIA-766 Deduplicate sb mempool asserts (#18175)

bce4b4a

Deduplicate sb mempool asserts.

Fix backwards compatibility for add_private_key (#18237)

a83f59b

* Fix backwards compatibility for `add_private_key` * Another backwards compatibility fix

Refactor CLI by adding add new click types for fees, amounts, address…

a447734

…es and bytes32 (#15718)

CHIA-801 Cover AGG_SIG_ME_ADDITIONAL_DATA in message construction for…

b705350

… test_agg_sig_illegal_suffix (#18235) Cover AGG_SIG_ME_ADDITIONAL_DATA in message construction for test_agg_sig_illegal_suffix.

Merge commit '9e1a4dceb724d7ebf56e3d8a75e8692184997805' into catchup/…

17e52c5

…long_lived_vault_from_main_9e1a4dceb724d7ebf56e3d8a75e8692184997805

Quexington changed the base branch from main to long_lived/vault June 26, 2024 18:07

Quexington closed this Jun 26, 2024

Quexington reopened this Jun 26, 2024

Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jun 26, 2024

Bring Wallet into conformity with MainWalletProtocol

844cb8e

Quexington marked this pull request as ready for review June 26, 2024 20:05

Quexington requested review from altendky and a team as code owners June 26, 2024 20:05

github-actions bot added the coverage-diff label Jun 27, 2024

altendky approved these changes Jun 27, 2024

View reviewed changes

geoffwalmsley approved these changes Jul 2, 2024

View reviewed changes

markelrod approved these changes Jul 8, 2024

View reviewed changes

cmmarslender approved these changes Jul 8, 2024

View reviewed changes

Quexington merged commit 57198e2 into long_lived/vault Jul 8, 2024
371 of 372 checks passed

Quexington deleted the catchup/long_lived_vault_from_main_9e1a4dceb724d7ebf56e3d8a75e8692184997805 branch July 8, 2024 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

catchup: long_lived/vault from main @ 9e1a4dceb724d7ebf56e3d8a75e8692184997805 #18258

catchup: long_lived/vault from main @ 9e1a4dceb724d7ebf56e3d8a75e8692184997805 #18258

Quexington commented Jun 26, 2024 •

edited

Loading

socket-security bot commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 27, 2024

markelrod left a comment

catchup: long_lived/vault from main @ 9e1a4dceb724d7ebf56e3d8a75e8692184997805 #18258

catchup: long_lived/vault from main @ 9e1a4dceb724d7ebf56e3d8a75e8692184997805 #18258

Conversation

Quexington commented Jun 26, 2024 • edited Loading

socket-security bot commented Jun 26, 2024 • edited Loading

github-actions bot commented Jun 27, 2024

markelrod left a comment

Choose a reason for hiding this comment

Quexington commented Jun 26, 2024 •

edited

Loading

socket-security bot commented Jun 26, 2024 •

edited

Loading