Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

More stuff to port #9

Closed
11 of 19 tasks
Chik3r opened this issue Aug 1, 2021 · 0 comments
Closed
11 of 19 tasks

More stuff to port #9

Chik3r opened this issue Aug 1, 2021 · 0 comments

Comments

@Chik3r
Copy link
Owner

Chik3r commented Aug 1, 2021

in unit_test branch

  • ModContent.TextureExists to HasAsset
  • SimpleIdentifierRewriter not visiting methods (will have to remove this probably: {Parent: MemberAccessExpressionSyntax})
  • SimpleIdentifierRewriter, NeededUsing virtual property (default to "Terraria.ModLoader"), and add the using
  • GlobalItem.NewPreReforge -> PreReforge
  • Property rewriter and the damage class rewriters clash
  • ModItem.NetRecieve -> ModItem.NetReceive
  • (GlobalTile/GlobalWall/ModTile/ModWall/ModBuff/ModDust/ModMount/ModPrefix).SetDefaults -> (X).SetStaticDefaults
  • Port moved assets #3
  • Port string mod.XType #5
  • porting issues #6
  • item.owner is now item.playerIndexTheItemIsReservedFor
  • Mod.GetTexture and ModContent.GetTexture #7 (need to add .Value)
  • ModTile.NewRightClick -> ModTile.RightClick
  • Terraria.ModLoader.NPCSpawnHelper -> Terraria.ModLoader.Utilities.NPCSpawnHelper (add using if missing)
  • >>> it would be nice if there was a way to detect if the NewProjectile call is within a ModProjectile/GlobalProjectile context, then you could automatically provide Projectile.InheritSource for the first parameter. Similar for ModTile/GlobalTile and the tile context one
  • "in Mod.AddRecipes, any code that isn't directly a ModRecipe recipe = "section" is completely deleted"
  • UISidebar.Visible = false is commented out. Figure out why this happens
  • "you can add the 1.3 Autoload hook on items/projectiles etc to the list of things to autoport because now IsLoadingEnabled exists"
  • "does your tmodporter work on already ported or partially ported mods?"
@Chik3r Chik3r closed this as completed Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant