Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong code documentation on HotChocolateDataRequestBuilderExtensions.AddSorting() and HotChocolateDataRequestBuilderExtensions.AddProjections() #4879

Closed
1 task done
kondelik opened this issue Mar 19, 2022 · 1 comment · Fixed by #4899

Comments

@kondelik
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

There is only single doc comment inside HotChocolateDataRequestBuilderExtensions copy pasted to all methods.

/// <summary>
/// Adds filtering support.
/// </summary>
/// <param name="builder">
/// The <see cref="IRequestExecutorBuilder"/>.
/// </param>
/// <param name="name">
/// The filter convention name.
/// </param>
/// <returns>
/// Returns the <see cref="IRequestExecutorBuilder"/>.
/// </returns>

AddSorting() and AddProjections() should not have IntelliSense about filtering.

Copy - paste and no reviewer 😄 What could go wrong... 🤣

Steps to reproduce

In Visual Studio (IntelliSense)

  1. hover mouse over services.AddGraphQLServer().(...).AddProjections()
  2. hover mouse over services.AddGraphQLServer().(...).AddSorting()

Relevant log output

No response

Additional Context?

No response

Product

Hot Chocolate

Version

12.6.0

@tobias-tengler
Copy link
Collaborator

If you want to, you can create a PR and fix the descriptions.
We'd love your contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants