Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo federation] map injection doesn't work in reference resolver #5872

Closed
1 task done
dariuszkuc opened this issue Feb 20, 2023 · 1 comment
Closed
1 task done
Labels
Area: Apollo Federation Issue is related to Apollo Federation 🌶️ hot chocolate
Milestone

Comments

@dariuszkuc
Copy link
Contributor

dariuszkuc commented Feb 20, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Product

Hot Chocolate

Describe the bug

When implementing Federation reference resolver it should be possible to inject parameters using Map["some.key"] syntax. Syntax works when there are other keys present (link) but fails when we only use map key (link).

Steps to reproduce

  1. Check out https://github.com/apollographql/apollo-federation-subgraph-compatibility/tree/hotchocolate
  1. Build test harness by running make setup (from root project directory)
  2. Run make test subgraph=hotchocolate (from root project directory)
  3. See that test verifying composite key (@key (composite)) fails

Relevant log output

No response

Additional Context?

If you update the entity resolver of ProductResearch (linked above) type to use ObjectValueNode you can see that received entity object reference has expected values.

Version

13.0.0

@tobias-tengler tobias-tengler added 🌶️ hot chocolate Area: Apollo Federation Issue is related to Apollo Federation labels Feb 20, 2023
@michaelstaib michaelstaib added this to the HC-13.1.0 milestone Feb 21, 2023
@michaelstaib michaelstaib modified the milestones: HC-13.1.0, HC-13.2.0 Apr 27, 2023
@dariuszkuc
Copy link
Contributor Author

resolved by #6596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Apollo Federation Issue is related to Apollo Federation 🌶️ hot chocolate
Projects
None yet
Development

No branches or pull requests

3 participants