You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have some non-standard behavior for Mongo filters. We have some "dynamic" data, that we resolve at runtime. But we can implement our logic for non-pagination queries very easily. We can override method MongoDbCollectionExecutable<T>.ToListAsync(). And it works perfectly!
But when we run pagination queries, HotChocolate uses method MongoDbCollectionExecutable<T>.BuildPipeline() that is not virtual. And we can't override this method. Basically we need to implement minor changes with filters inside this method also.
The solution you'd like
It would be great, if you approve marking method MongoDbCollectionExecutable<T>.BuildPipeline() as virtual. In this case we could implement our logic with minimal changes. Also we could mark this method in another classes (MongoDbFindFluentExecutable and MongoDbAggregateFluentExecutable)
I would be glad to make a PR if you accept it.
Looking forward any feedback.
Thanks in advance!
The text was updated successfully, but these errors were encountered:
Product
Hot Chocolate
Is your feature request related to a problem?
We have some non-standard behavior for Mongo filters. We have some "dynamic" data, that we resolve at runtime. But we can implement our logic for non-pagination queries very easily. We can
override
methodMongoDbCollectionExecutable<T>.ToListAsync()
. And it works perfectly!But when we run pagination queries, HotChocolate uses method
MongoDbCollectionExecutable<T>.BuildPipeline()
that is notvirtual
. And we can't override this method. Basically we need to implement minor changes with filters inside this method also.The solution you'd like
It would be great, if you approve marking method
MongoDbCollectionExecutable<T>.BuildPipeline()
as virtual. In this case we could implement our logic with minimal changes. Also we could mark this method in another classes (MongoDbFindFluentExecutable
andMongoDbAggregateFluentExecutable
)I would be glad to make a PR if you accept it.
Looking forward any feedback.
Thanks in advance!
The text was updated successfully, but these errors were encountered: