Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken sidenav #2757

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fix broken sidenav #2757

merged 2 commits into from
Jan 8, 2021

Conversation

fredericbirke
Copy link
Contributor

@fredericbirke fredericbirke commented Dec 14, 2020 •
edited by rstaib
Loading

No description provided.

@michaelstaib michaelstaib requested a review from rstaib December 15, 2020 11:19
@fredericbirke fredericbirke marked this pull request as ready for review December 16, 2020 21:43
@fredericbirke fredericbirke marked this pull request as draft December 16, 2020 21:49
@fredericbirke fredericbirke force-pushed the fb/website branch 3 times, most recently from 76e81db to 3c81d2f Compare December 18, 2020 18:10
@fredericbirke fredericbirke marked this pull request as ready for review December 18, 2020 18:17
rstaib
rstaib requested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support and Platform page broken. Also a few other things are not working as expected. Perhaps we should do a Zoom call.

@fredericbirke fredericbirke force-pushed the fb/website branch 3 times, most recently from 8033f1e to 42455a5 Compare January 2, 2021 12:58
@fredericbirke fredericbirke requested a review from rstaib January 2, 2021 12:59
@fredericbirke fredericbirke force-pushed the fb/website branch 3 times, most recently from 50cbbc8 to 7464a5a Compare January 8, 2021 15:57
rstaib
rstaib approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done sir!

@rstaib rstaib merged commit cdc5824 into main Jan 8, 2021
@rstaib rstaib deleted the fb/website branch January 8, 2021 22:40
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaib rstaib rstaib approved these changes

Assignees

@fredericbirke fredericbirke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredericbirke @rstaib @michaelstaib