-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document custom request size limits with Multipart #3494
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Oh, I think I forgot to run tests again, after including the Exception. I will fix it! |
@michaelstaib I thought adding the exception to the ErrorBuilder would include it in the output, but it isn't inlcuded: |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Adding the exception will make the exception available to internal diagnostics. This means that if you attach a logger or intercept the error you will be able to catch it. If you want to expose the internal error message you should also add an extension field to the error: ErrorBuilder.New()
....
.SetExtension("underlyingError", ex.Message) Just add this additionally. |
Added the extension field and also added a test that showcases what happens if a file is uploaded that exceeds limits. |
/AzurePipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
@tobias-tengler I have given you write access to the repo, you can now add your own branches to the main repo which makes contributing easier. The branch names are structured like follows: example |
Kudos, SonarCloud Quality Gate passed! |
I added a note about request size limits to the documentation.
I also changed one of the existing multipart error messages to include the exception detailing why the parsing of the multipart form failed. This should help debugging issues related to request sizes and badly formed multipart requests.
Relates to #3473