Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3628 add support for IsRepeatable not being specified on directives #3629

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

nloum
Copy link
Contributor

@nloum nloum commented Apr 30, 2021

Add support for IsRepeatable not being specified in GraphQL schemas

  • Directive.IsRepeatable becomes nullable
  • When Directive.IsRepeatable is null, code assumes that the the directive is not repeatable

Closes #3628

@michaelstaib
Copy link
Member

Awesome! Thanks for not only filing an issue but also fixing it!

@michaelstaib
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelstaib michaelstaib merged commit f5f4019 into ChilliCream:main Apr 30, 2021
@michaelstaib
Copy link
Member

Will be included into 11.3.0-preview.5

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet-graphql fails to download schema from Hasura
2 participants