Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul "Defining a schema" documentation #3662

Merged
merged 61 commits into from
Jun 2, 2021

Conversation

tobias-tengler
Copy link
Collaborator

@tobias-tengler tobias-tengler commented May 5, 2021

This changes the sidebar layout of the "Defining a schema" section:

I've also added the missing pieces that were left unfinished and checked the other parts for completeness / correctness.

I plan on covering Resolvers in a next PR.

@tobias-tengler tobias-tengler added the 📚 documentation This issue is about working on our documentation. label May 6, 2021
@tobias-tengler tobias-tengler force-pushed the tte/definining-schema-docs branch 4 times, most recently from ae06ffd to 435834c Compare May 14, 2021 11:49
@tobias-tengler tobias-tengler force-pushed the tte/definining-schema-docs branch from 435834c to 5d54f54 Compare May 14, 2021 16:37
@tobias-tengler
Copy link
Collaborator Author

@benmccallum I'm almost done! With some input from Michael around type extensions tonight, I'm confident I can finish this today. I think we can postpone the scalar stuff and just launch it as is, but we can discuss tonight.

tobias-tengler and others added 2 commits June 2, 2021 14:29
…s.md

Co-authored-by: Ben McCallum <ben.mccallum@live.com.au>
…s.md

Co-authored-by: Ben McCallum <ben.mccallum@live.com.au>
@tobias-tengler tobias-tengler added the 🎬 ready Ready to merge label Jun 2, 2021
@tobias-tengler tobias-tengler force-pushed the tte/definining-schema-docs branch from 9ca676f to 16e8e3e Compare June 2, 2021 12:40
@tobias-tengler tobias-tengler force-pushed the tte/definining-schema-docs branch from 24bf2cc to 35ee5f3 Compare June 2, 2021 13:08
michaelstaib
michaelstaib previously approved these changes Jun 2, 2021
@tobias-tengler tobias-tengler force-pushed the tte/definining-schema-docs branch from ddbb984 to 00a27d6 Compare June 2, 2021 13:44
@michaelstaib michaelstaib merged commit 2d33a7f into main Jun 2, 2021
@michaelstaib michaelstaib deleted the tte/definining-schema-docs branch June 2, 2021 13:49
@wonbyte
Copy link
Contributor

wonbyte commented Jun 2, 2021

@benmccallum I'm almost done! With some input from Michael around type extensions tonight, I'm confident I can finish this today. I think we can postpone the scalar stuff and just launch it as is, but we can discuss tonight.

@tobias-tengler let me know if you have any questions around the Scalars

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation This issue is about working on our documentation. 🎬 ready Ready to merge 🌶️ website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants