Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve scalar stitching in delegated fields #1221

Merged
merged 16 commits into from
Dec 11, 2019
Merged

Resolve scalar stitching in delegated fields #1221

merged 16 commits into from
Dec 11, 2019

Conversation

nigel-sampson
Copy link
Contributor

@nigel-sampson nigel-sampson commented Nov 22, 2019 •
edited
Loading

Resolves #1220

@nigel-sampson nigel-sampson changed the base branch from master to version_10_0_0_master November 22, 2019 07:26
@nigel-sampson nigel-sampson mentioned this pull request Nov 22, 2019
Closed
@michaelstaib michaelstaib added this to the 10.3.0 milestone Nov 22, 2019
nigel-sampson pushed a commit that referenced this pull request Dec 3, 2019
Create failing test (#1221)
4984a7f
nigel-sampson pushed a commit that referenced this pull request Dec 3, 2019
Don't append __typename if it's already being selection (#1221)
ae72f1a
nigel-sampson pushed a commit that referenced this pull request Dec 3, 2019
Create failing test (#1221)
6a79e72
nigel-sampson pushed a commit that referenced this pull request Dec 3, 2019
Don't append __typename if it's already being selection (#1221)
23b86f3
@michaelstaib michaelstaib changed the title Resolve scalar stitching in delegated fields 🚧 Resolve scalar stitching in delegated fields Dec 5, 2019
@michaelstaib
Copy link
Member

OK, the issue is that the gateway tries to deserialize the types. I think they should be kept as literals .

@michaelstaib
Copy link
Member

Found the issue... I have to check what a change their impacts... But I think we can keep the stricter argument validation and change the scoped variable handlers to only use literals. That would be the best outcome...

Have a talk tonight will look into fixing this tomorrow... I will put this in preview.8

@michaelstaib michaelstaib changed the title 🚧 Resolve scalar stitching in delegated fields Resolve scalar stitching in delegated fields Dec 11, 2019
@michaelstaib
Copy link
Member

This one has quite an impact.

@michaelstaib michaelstaib merged commit 82105ee into version_10_0_0_master Dec 11, 2019
@michaelstaib michaelstaib deleted the stitching-scalar-serialization branch December 11, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nigel-sampson nigel-sampson

@michaelstaib michaelstaib

Labels
None yet
Projects
None yet
Milestone
HC-10.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nigel-sampson @michaelstaib