fix(DI): fix hashprovider DI which has multiple constructors #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
reviewed
Jan 9, 2020
|
@OneCyrus do you also want to do a fix on the 10.3.x branch? We can include it in a 10.3.4. The branch for that is version_10_0_0_master. We do no longer merge the branches since the 11 release now split so you would need a second PR for that, that branches of version_10_0_0_master. |
|
Yes, this fixes #1305 fully. And I can do another PR for 10 |
michaelstaib
approved these changes
Jan 9, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
michaelstaib
pushed a commit
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD5DocumentHashProvider has multiple constructors which doesn't work properly with DI. this change specifies the constructor explicitly.
Fixes #1305